Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fidelity cma csv importer #47

Merged
merged 5 commits into from
Jan 28, 2023
Merged

Fidelity cma csv importer #47

merged 5 commits into from
Jan 28, 2023

Conversation

kantskernel
Copy link
Contributor

@kantskernel kantskernel commented Jan 27, 2023

Changes here are:

  • importer for Fidelity Cash Management account (CSV)
  • an example
  • minor change to csvreader

I didn't realize there was already an effort to get this working with OFX. I just saw this today:
#41

If we'd rather not support CSV since it seems that OFX is a better option, that is okay with me. I plan to try the OFX later. Just wanted to share what I've been working with.

A couple other comments:

  • it looks like banking.py enforces both a payee and a narration so that is why I split up "Action" into payee and memo
  • there is probably a nicer way to iterate through the Action rows (removing all of my if statements). I'm open to any feedback

@kantskernel
Copy link
Contributor Author

I've been looking at ways to simplify prepare_raw_columns-- rdr.split() looks promising. Just trying to get the right regex. It would also be an option to create a payee column but leave it blank and then just use the "Action" column as narration/memo

@redstreet
Copy link
Owner

Nice, clean importer, with the test data---thanks! Happy to merge this in. A couple notes:

  • I'll change the directory structure to match the new one-per-institution
  • You're right, ofx files are far better than csvs in my experience, and I'd strongly recommend using ofx when available. Fidelity is particularly good because they still support direct downloads. However, the csv importer here comes in handy if you want to import data older than 90 days, which ofx might not support.

@redstreet redstreet merged commit 583d5e3 into redstreet:main Jan 28, 2023
@redstreet
Copy link
Owner

Done in 98c967c. Thanks again!

@redstreet
Copy link
Owner

I like your rdr.capture() approach. Nice find! Just mentioned it here FYI.

scanta2 pushed a commit to scanta2/beancount_reds_importers that referenced this pull request Jan 5, 2024
* adding support for importering Fidelity Cash Management Acct (checking). CSV.

* cleaned up importer and merged required csvreader change with the version from main

* addressing git action checks

* resolving invalid escape seq. in header_identifier

* resolving pep8 errors

---------

Co-authored-by: Colton Crivelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants