Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Migration - Popover Component #815

Merged
merged 18 commits into from
Sep 8, 2023
Merged

Conversation

frankieshakes
Copy link
Contributor

@frankieshakes frankieshakes commented Aug 18, 2023

Moved all Popover components instances to use the new Redpanda Popover component. The new component allows for props to specify the title and content of the popover.

*** PR is dependent on this PR from the UI library. Do not merge until package.json has been updated to that version. (now updated)

Screenshots

Screenshot 2023-08-17 at 10 53 15 AM Screenshot 2023-08-17 at 10 53 03 AM Screenshot 2023-08-17 at 10 52 41 AM Screenshot 2023-08-17 at 10 52 21 AM

@frankieshakes
Copy link
Contributor Author

frankieshakes commented Aug 18, 2023

The Frontend Lint & Compile check is failing because the version of @redpanda-data/ui in package.json isn't the latest version with the Popover component. Once the UI library PR is approved, we can update package.json with the latest version, which should fix the build issues.

@frankieshakes frankieshakes marked this pull request as ready for review September 7, 2023 20:50
@frankieshakes frankieshakes merged commit 3bfeae1 into master Sep 8, 2023
6 checks passed
@frankieshakes frankieshakes deleted the fmanno/popover-migration branch September 8, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants