Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out Redpanda internal topics for MirrorMaker 2 connector #802

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Filter out Redpanda internal topics for MirrorMaker 2 connector #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/pkg/connector/interceptor/mirror_hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ func KafkaConnectToConsoleMirrorSourceHook(response model.ValidationResponse, _
Definition: model.ConfigDefinitionKey{
Name: "topics.exclude",
Type: "LIST",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
Importance: "MEDIUM",
Required: false,
DisplayName: "Topics exclude",
Documentation: "Excluded topics. Supports comma-separated topic names and regexes",
},
Value: model.ConfigDefinitionValue{
Name: "topics.exclude",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
RecommendedValues: []string{},
Visible: true,
Errors: []string{},
Expand Down
12 changes: 6 additions & 6 deletions backend/pkg/connector/interceptor/mirror_hook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,15 @@ func TestKafkaConnectToConsoleMirrorSourceHook(t *testing.T) {
Definition: model.ConfigDefinitionKey{
Name: "topics.exclude",
Type: "LIST",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
Importance: "MEDIUM",
Required: false,
DisplayName: "Topics exclude",
Documentation: "Excluded topics. Supports comma-separated topic names and regexes",
},
Value: model.ConfigDefinitionValue{
Name: "topics.exclude",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
RecommendedValues: []string{},
Visible: true,
Errors: []string{},
Expand Down Expand Up @@ -609,15 +609,15 @@ func TestKafkaConnectToConsoleMirrorSourceHook(t *testing.T) {
Definition: model.ConfigDefinitionKey{
Name: "topics.exclude",
Type: "LIST",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
Importance: "MEDIUM",
Required: false,
DisplayName: "Topics exclude",
Documentation: "Excluded topics. Supports comma-separated topic names and regexes",
},
Value: model.ConfigDefinitionValue{
Name: "topics.exclude",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
RecommendedValues: []string{},
Visible: true,
Errors: []string{},
Expand Down Expand Up @@ -922,15 +922,15 @@ func TestKafkaConnectToConsoleMirrorSourceHook(t *testing.T) {
Definition: model.ConfigDefinitionKey{
Name: "topics.exclude",
Type: "LIST",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
DefaultValue: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
Importance: "MEDIUM",
Required: false,
DisplayName: "Topics exclude",
Documentation: "Excluded topics. Supports comma-separated topic names and regexes",
},
Value: model.ConfigDefinitionValue{
Name: "topics.exclude",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas",
Value: ".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas",
RecommendedValues: []string{},
Visible: true,
Errors: []string{},
Expand Down
2 changes: 1 addition & 1 deletion backend/pkg/connector/patch/mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func (*ConfigPatchMirrorSource) PatchDefinition(d model.ConfigDefinition, connec
d.SetDocumentation("Replication factor for newly created remote topics. Set -1 for cluster default").
SetDefaultValue("-1")
case "topics.exclude":
d.SetDefaultValue(".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.cloud.sla_verification,_internal_connectors.*,_schemas")
d.SetDefaultValue(".*[\\-\\.]internal,.*\\.replica,__consumer_offsets,_redpanda_e2e_probe,__redpanda.*,_internal_connectors.*,_schemas")
case "sync.group.offsets.enabled":
d.SetDefaultValue("true")
case name:
Expand Down
Loading