console: Move to rspack/rsbuild #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
2 times, most recently
from
d9af571
to
ed980c6
Compare
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
2 times, most recently
from
d72e821
to
e24a2ac
Compare
malinskibeniamin
changed the title
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
from
e24a2ac
to
6ba800a
Compare
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
from
6ba800a
to
7f2c862
Compare
malinskibeniamin
changed the title
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
from
7f2c862
to
86c9573
Compare
sago2k8
force-pushed
the
chore/move-console-to-rspack
branch
3 times, most recently
from
da8f5c5
to
96d79f7
Compare
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
2 times, most recently
from
df371c0
to
0a5d9c8
Compare
sago2k8
force-pushed
the
chore/move-console-to-rspack
branch
2 times, most recently
from
0f15272
to
2360825
Compare
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
5 times, most recently
from
7b698a5
to
7e5e156
Compare
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
3 times, most recently
from
617f0f2
to
f1643c3
Compare
malinskibeniamin
force-pushed
the
chore/move-console-to-rspack
branch
from
23debd4
to
7dcdb52
Compare
sago2k8
approved these changes
Oct 11, 2024
| } |
There was a problem hiding this comment.
[nit]: could you make your editor add EOF line, so there are no formatting changes.
There was a problem hiding this comment.
I have "files.insertFinalNewline": true because there should be an EOF line always, now it's there (previously there wasn't any EOF character)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to other PRs, we would like to use rspack and stay consistent with the other Cloud UIs.
This PR paves the way towards enhanced module federation usage, and cloud UI PR is also being migrated rspack for that reason.
The build + start commands are already working.
Needs extensive checks (I didn't have console fully set up to try out locally e2e)
We also added rsdoctor plugin which is a tool for bundle analysis.
We also have monaco editor supported with YAML schema configurations and auto-complete.
https://github.com/web-infra-dev/rspack/releases
https://rspack.dev/blog/announcing-1-0
https://github.com/rspack-contrib/performance-compare
https://x.com/rspack_dev
https://rspack.dev/guide/migration/cra
https://rspack.dev/guide/features/module-federation
Example build
npm run build
npm run start
chore.move-console-to-rspack-console-standalone.mov