Merge pull request #822 from redpanda-data/bq-conn-enh

Add kafkaKeyFieldName to BigQuery sink connector guide
redpanda-data · Aug 23, 2023 · 4c2149d · 4c2149d
2 parents 76c261d + 24a850d
commit 4c2149d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/backend/pkg/connector/guide/bigquery_sink.go b/backend/pkg/connector/guide/bigquery_sink.go
@@ -44,6 +44,7 @@ func NewBigQuerySinkGuide(opts ...Option) Guide {
 						// No Group name and description here
 						ConfigKeys: append([]string{
 							"key.converter",
+							"key.converter.schemas.enable",
 							"value.converter",
 							"value.converter.schemas.enable",
 							"autoCreateTables",
@@ -52,6 +53,7 @@ func NewBigQuerySinkGuide(opts ...Option) Guide {
 							"allowBigQueryRequiredFieldRelaxation",
 							"upsertEnabled",
 							"deleteEnabled",
+							"kafkaKeyFieldName",
 							"timePartitioningType",
 							"bigQueryRetry",
 							"bigQueryRetryWait",

diff --git a/backend/pkg/connector/patch/bigquery_sink.go b/backend/pkg/connector/patch/bigquery_sink.go
@@ -51,8 +51,6 @@ func (c *ConfigPatchBigQuery) IsMatch(configKey, connectorClass string) bool {
 func (*ConfigPatchBigQuery) PatchDefinition(d model.ConfigDefinition, _ string) model.ConfigDefinition {
 	// Misc patches
 	switch d.Definition.Name {
-	case keyConverter:
-		d.SetImportance(model.ConfigDefinitionImportanceLow)
 	case valueConverter:
 		d.ClearRecommendedValuesWithMetadata().
 			AddRecommendedValueWithMetadata("io.confluent.connect.avro.AvroConverter", "AVRO").
@@ -82,6 +80,8 @@ func (*ConfigPatchBigQuery) PatchDefinition(d model.ConfigDefinition, _ string)
 		d.SetDisplayName("Upsert enabled")
 	case "deleteEnabled":
 		d.SetDisplayName("Delete enabled")
+	case "kafkaKeyFieldName":
+		d.SetDisplayName("Kafka key field name")
 	case "bigQueryRetry":
 		d.SetDisplayName("BigQuery retry attempts")
 	case "bigQueryRetryWait":
@@ -97,7 +97,9 @@ func (*ConfigPatchBigQuery) PatchDefinition(d model.ConfigDefinition, _ string)
 	switch d.Definition.Name {
 	case "keyfile":
 		d.SetImportance(model.ConfigDefinitionImportanceHigh)
-	case "autoCreateTables":
+	case keyConverter,
+		"autoCreateTables",
+		"kafkaKeyFieldName":
 		d.SetImportance(model.ConfigDefinitionImportanceMedium)
 	}