-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PeerDB input plugin for handling Postgres CDC #2596
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kaushik Iska <[email protected]>
e1eccd6
to
464a224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about the name here. Has this something to do with PeerDB and their (commercial) offering? Or would you just share the name because the concept is the same...? https://github.com/jackc/pglogrepl doesn't mention "peerdb" anywhere.
|
||
// Run a postgres container | ||
resource, err := pool.RunWithOptions(&dockertest.RunOptions{ | ||
Repository: "debezium/postgres", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this significant? Would the stock postgres image be missing extensions..? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image has some changes to the default postgres image, it isn't hard to get this in there but was more convenient to just is it, specifically
wal_level = logical
max_wal_senders = <N > 0>
max_replication_slots = < N > 0>
I'm just a passer-by reviewing what looked like a very cool addition. Please bear with me 😅 |
Thanks for taking the time to look at the PR =) |
@iskakaushik I'm still confused about the "peerdb" name (see previous comment). Could you clear that up for me? 😅 |
pglogrepl
- https://github.com/jackc/pglogrepl.