Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the text logo to image #274

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tdtgit
Copy link

@tdtgit tdtgit commented Oct 1, 2024

This PR is for #203 , to change current text logo to <img> tag with the source image already existed in the source code.

The image width is now 38px, a little bit bigger than 36px. Let me know if it's okay.

It will look like this on:
Mobile:
image

Desktop:
image

@tdtgit tdtgit changed the title Change the logo to <img> for #203 Change the text logo to image Oct 1, 2024
@DokterKaj
Copy link
Contributor

DokterKaj commented Oct 6, 2024

If you used an SVG instead of a PNG, you could theme colours of the logo like this (code from my PR #280):

<svg version="1.1" viewBox="0 0 512 512" width="38" height="38" xmlns="http://www.w3.org/2000/svg">
  <g transform="matrix(1 0 0 -1 0 512)">
    <circle cx="256" cy="256" r="256" fill="var(--outside)"/>
    <path d="M240,96 v226 h70 v-156 h58 V96 z" fill="var(--text)"/>
    <path d="M144,96 v320 h224 v-70 h-152 V96 z" fill="var(--accent)"/>
  </g>
</svg>

Not sure what colours to use though; I thought about making the circle var(--text) and the L var(--outside) but some accent colours are quite light and don't look good on a white background. The code above makes the circle the same colour as the navbar so maybe it might be better to simply remove the circle altogether.

What do you think about having the RL symbol without the circle and then "redlib" in text next to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants