Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a failure of a test case for a cluster client #1275

Merged
merged 1 commit into from
May 2, 2024

Conversation

supercaracal
Copy link
Contributor

The version 0.9.0 of redis-cluster-client was released. It made MSET, MGET and DEL commands able to pass multiple keys without a hashtag by using pipelining. Although the performance is degradated, I think it may be useful in some use cases. So, because the behavior was changed, This pull request fixes a failure of a test case for a cluster client.

@supercaracal
Copy link
Contributor Author

  1) Failure:
TestClusterClientReplicas#test_client_can_command_with_replica [cluster/test/client_replicas_test.rb:19]:
--- expected
+++ actual
@@ -1,3 +1 @@
-# encoding: US-ASCII
-#    valid: true
-"1"
+nil

The above failure isn't related this pull request. It may be flaky. Please ignore it on this pull request. I'll look into and work on it if it occurs frequently.

@supercaracal supercaracal marked this pull request as ready for review May 2, 2024 12:31
@byroot byroot merged commit 15c8c92 into redis:master May 2, 2024
15 of 17 checks passed
@supercaracal supercaracal deleted the fix-cluster-test branch May 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants