Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default value to match sync cluster API #3434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vladvildanov
Copy link
Collaborator

@vladvildanov vladvildanov commented Nov 15, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The goal of this PR if to fix misalignment between the default value of require_full_coverage configuration option for sync/async clients. The default value was chosen to be True by default for safety reasons.

@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Nov 15, 2024
@akx
Copy link
Contributor

akx commented Nov 15, 2024

What does this PR mean to do? It's not clear from the title, description, or commit message?

@vladvildanov
Copy link
Collaborator Author

@akx Sorry for this, the PR description was updated

@akx
Copy link
Contributor

akx commented Nov 18, 2024

@vladvildanov Should the word "much" in the title be "match"? 😅

@vladvildanov vladvildanov changed the title Updated default value to much sync cluster API Updated default value to match sync cluster API Nov 18, 2024
@vladvildanov
Copy link
Collaborator Author

@akx Oh, thank you! 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants