Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connection initialize flag works as expected #2835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YorigamiShion
Copy link

I think flag atomicBoolean here is expected to make sure only one thread executes sync.getConncetion().whenComplete to remove the Sync from map when init is fail. However, the original implmentation will allow all threads execute whenComplete if the connection is not initialized.
Furthermore, call connections.get then connections.computeIfAbsent is unnecessary.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (43843bf) to head (004b471).
Report is 251 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2835      +/-   ##
============================================
- Coverage     78.71%   77.69%   -1.03%     
- Complexity     6786     7236     +450     
============================================
  Files           508      539      +31     
  Lines         22765    24492    +1727     
  Branches       2446     2606     +160     
============================================
+ Hits          17919    19028    +1109     
- Misses         3717     4266     +549     
- Partials       1129     1198      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mp911de
Copy link
Collaborator

mp911de commented Apr 25, 2024

Care to elaborate what kind of issue you're addressing before we jump right into the code?

@tishun tishun added the status: waiting-for-feedback We need additional information before we can continue label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants