Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for docker secrets #355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kitingChris
Copy link

To pass the value for --requirepass password in a secure way docker secrets can be used with this pr.

If a secrets file is available and not empty it the password is passed to the server option --requirepass

Reads the requirepass password from a docker secrets file
@tianon
Copy link
Contributor

tianon commented Apr 11, 2023

Duplicate of #268

(see especially #268 (comment))

@kitingChris
Copy link
Author

This is not an issue but an pull request. It solves #268.
While the ACL approach may be the better solution my goal only was to get it running with requirepass and passing the password as secret.

@tianon
Copy link
Contributor

tianon commented Apr 11, 2023

When we said we didn't plan to implement it, we also meant we didn't plan to accept/maintain the code (sorry for the lack of explicit clarity there).

@kitingChris
Copy link
Author

kitingChris commented Apr 11, 2023

And why is it not planned to implement it? It is not a very complex code.

EDIT: the requirepass functionality is in many scenarios still the most used one. In my case with nextcloud. Using an ACL would mean to manage the password in 2 separate ways instead of one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants