Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one errors in rate limiting samples. #613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix off-by-one errors in rate limiting samples. #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad1c3a8
Fix off-by-one error in fixed-window rate limiting sample
kimsey0 Sep 4, 2023
09539f8
Fix off-by-one error in sliding-window rate limiting sample
kimsey0 Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/develop/dotnet/aspnetcore/rate-limiting/fixed-window/fixed-window.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ The issue we need to contend with here is that this rate-limiting requires atomi
local expiry = tonumber(ARGV[2])
local requests = redis.call('INCR',key)
redis.call('EXPIRE', key, expiry)
if requests < max_requests then
if requests <= max_requests then
return 0
else
return 1
Expand All @@ -126,7 +126,7 @@ Alternatively, StackExchange.Redis contains support for a [more readable mode of
```sh
local requests = redis.call('INCR',@key)
redis.call('EXPIRE', @key, @expiry)
if requests < tonumber(@maxRequests) then
if requests <= tonumber(@maxRequests) then
return 0
else
return 1
Expand All @@ -148,7 +148,7 @@ To run a Lua script with StackExchange.Redis, you need to prepare a script and r
private const string RATE_LIMITER = @"
local requests = redis.call('INCR',@key)
redis.call('EXPIRE', @key, @expiry)
if requests < tonumber(@maxRequests) then
if requests <= tonumber(@maxRequests) then
return 0
else
return 1
Expand Down Expand Up @@ -207,7 +207,7 @@ You will see some of your requests return a `200`, and at least one request retu
HTTP 200, 0.001492 s
HTTP 200, 0.001449 s
HTTP 200, 0.001551 s
{"status":429,"traceId":"00-16e9da63f77c994db719acff5333c509-f79ac0c862c5a04c-00"} HTTP 429, 0.001803 s
HTTP 200, 0.001551 s
{"status":429,"traceId":"00-3d2e4e8af851024db121935705d5425f-0e23eb80eae0d549-00"} HTTP 429, 0.001521 s
{"status":429,"traceId":"00-b5e824c9ebc4f94aa0bda2a414afa936-8020a7b8f2845544-00"} HTTP 429, 0.001475 s
{"status":429,"traceId":"00-bd6237c5d0362a409c436dcffd0d4a7a-87b544534f397247-00"} HTTP 429, 0.001549 s
Expand Down
4 changes: 2 additions & 2 deletions ...op/dotnet/aspnetcore/rate-limiting/sliding-window/index-sliding-rate-limiter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ local trim_time = tonumber(current_time[1]) - @window
redis.call('ZREMRANGEBYSCORE', @key, 0, trim_time)
local request_count = redis.call('ZCARD',@key)

if request_count < tonumber(@max_requests) then
if request_count <= tonumber(@max_requests) then
redis.call('ZADD', @key, current_time[1], current_time[1] .. current_time[2])
redis.call('EXPIRE', @key, @window)
return 0
Expand All @@ -140,7 +140,7 @@ namespace SlidingWindowRateLimiter
redis.call('ZREMRANGEBYSCORE', @key, 0, trim_time)
local request_count = redis.call('ZCARD',@key)

if request_count < tonumber(@max_requests) then
if request_count <= tonumber(@max_requests) then
redis.call('ZADD', @key, current_time[1], current_time[1] .. current_time[2])
redis.call('EXPIRE', @key, @window)
return 0
Expand Down