Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-24340) logind: tighten for which classes of sessions we do stop-on-idle #303

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

msekletar
Copy link
Member

@msekletar msekletar commented Nov 19, 2024

We only want to do this for fully set up, interactive sessions, i.e. user and user-early, but not for any others, hence restrict the rules a bit.

Follow-up for: 508b478

(cherry picked from commit ad23439)

Related: RHEL-24340

We only want to do this for fully set up, interactive sessions, i.e.
user and user-early, but not for any others, hence restrict the rules a
bit.

Follow-up for: 508b478

(cherry picked from commit ad23439)

Related: RHEL-24340
@github-actions github-actions bot added tracker/invalid-product pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Commit validation

Tracker - RHEL-24340

The following commits meet all requirements

commit upstream
e379378 - logind: tighten for which classes of sessions we do stop-on-idle systemd/systemd@ad23439

Tracker validation

Success

🟢 Tracker RHEL-24340 has set desired product: rhel-9.3.0
🟢 Tracker RHEL-24340 has set desired component: systemd
🟢 Tracker RHEL-24340 has been approved
🟢 Tracker RHEL-24340 has set severity


Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Nov 27, 2024
@jamacku jamacku added this to the RHEL-9.6.0 milestone Nov 27, 2024
@jamacku
Copy link
Member

jamacku commented Nov 27, 2024

@mrc0mmand Any idea what went wrong in mkosi centos9 check? Thank you

@mrc0mmand
Copy link
Member

@mrc0mmand Any idea what went wrong in mkosi centos9 check? Thank you

It's something EFI related:

 [  108.424399] mkosi-check-and-shutdown.sh[423]: + systemd-detect-virt --container
[  108.520224] mkosi-check-and-shutdown.sh[428]: none
[  108.532003] mkosi-check-and-shutdown.sh[423]: + cmp /sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c /dev/fd/63
[  108.546320] mkosi-check-and-shutdown.sh[429]: ++ printf '\6\0\0\0\1'
[  108.600790] mkosi-check-and-shutdown.sh[430]: /sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c /dev/fd/63 differ: byte 5, line 1

Not sure what changed in the underlying distro, but I don't think it's caused by this PR.

@jamacku
Copy link
Member

jamacku commented Nov 27, 2024

Thank you @mrc0mmand

@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Nov 27, 2024
@github-actions github-actions bot merged commit 8554520 into redhat-plumbers:main Nov 27, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants