(RHEL-26114) feat(dracut-init.sh): give --force-add precedence over --omit #95
Conversation
This gives precedence of force_add_dracutmodules to omit_dracutmodules, as there is not other way to override omit_dracutmodules list, and users would expect it to be overriden from command line. Ref: dracut-ng/dracut-ng#569 This way, `--add` retains it behaviour, and `--force-add` gains additional functionality in non-hostonly mode. The module may still be skipped if the module check returns 1, but it should throw error (as I'd expect for `--force-add`). Ref: https://issues.redhat.com/browse/RHEL-26114 (cherry picked from commit a669346f48cbb3278c51ba5e95b1b91f9bfdee0a) Resolves: RHEL-26114
github-actions
bot
changed the title
Commit validationTracker - RHEL-26114 The following commits need an inspection
Tracker validationSuccess🟢 Tracker RHEL-26114 has set desired product: Pull Request validationFailed🔴 Failed or pending checks - |
|
Tested in RHEL-10. Behaviour should be identical. LGTM. |
This gives precedence of force_add_dracutmodules to omit_dracutmodules,
as there is not other way to override omit_dracutmodules list, and users
would expect it to be overriden from command line.
Ref: dracut-ng/dracut-ng#569
This way,
--addretains it behaviour, and--force-addgains additionalfunctionality in non-hostonly mode. The module may still be skipped
if the module check returns 1, but it should throw error (as I'd expect
for
--force-add).Ref: https://issues.redhat.com/browse/RHEL-26114
(cherry picked from commit a669346f48cbb3278c51ba5e95b1b91f9bfdee0a)
Resolves: RHEL-26114