Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-27944) feat(systemd-pcrphase): introducing the systemd-pcrphase module #91

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Jul 27, 2024

Introducing the systemd-pcrphase module

(Cherry-picked commit: c4c595ceeab79fefde74750ec6b0d15d7d16ede6)

Resolves: RHEL-27944

Introducing the systemd-pcrphase module

(Cherry-picked commit: c4c595ceeab79fefde74750ec6b0d15d7d16ede6)

Resolves: RHEL-27944
@pvalena pvalena added the bug Something isn't working label Jul 27, 2024
@pvalena pvalena self-assigned this Jul 27, 2024
The only systemd-pcrphase related unit configured to run in the initrd is
systemd-pcrphase-initrd.service.
Both systemd-pcrphase.service and systemd-pcrphase-sysinit.service contain
`ConditionPathExists=!/etc/initrd-release`.

(Cherry-picked commit: cd6f683)

Related: RHEL-27944
@github-actions github-actions bot changed the title feat(systemd-pcrphase): introducing the systemd-pcrphase module (RHEL-27944) feat(systemd-pcrphase): introducing the systemd-pcrphase module Jul 27, 2024
Copy link

github-actions bot commented Jul 27, 2024

Commit validation

Tracker - RHEL-27944

The following commits need an inspection

commit note
f182e5e - feat(systemd-pcrphase): introducing the systemd-pcrphase module Missing upstream reference ‼️
8c247d1 - fix(systemd-pcrphase): only include systemd-pcrphase-initrd.service Missing upstream reference ‼️

Tracker validation

Success

🟢 Tracker RHEL-27944 has set desired product: rhel-9.5
🟢 Tracker RHEL-27944 has set desired component: dracut
🟢 Tracker RHEL-27944 has been approved


Pull Request validation

Failed

🔴 Failed or pending checks - testing-farm:centos-stream-9-x86_64[failure]
🔴 Review - Missing review from a member

@pvalena
Copy link
Contributor Author

pvalena commented Jul 27, 2024

LGTM.

@pvalena
Copy link
Contributor Author

pvalena commented Jul 27, 2024

@jamacku btw. how do I add the upstream reference? :) we have Cherry-picked commit: .... there, but that's probably not enough.

@pvalena pvalena merged commit 86ce704 into redhat-plumbers:main Jul 27, 2024
43 of 44 checks passed
@jamacku
Copy link
Member

jamacku commented Jul 28, 2024

@pvalena, just use git cherry-pick -x <sha>. It will produce references in the correct form for you.

@pvalena
Copy link
Contributor Author

pvalena commented Jul 30, 2024

Right, so it's just (cherry picked from commit ca5ae5d3466eec40d118fc96d450478aa6faebb6)
instead of the original one... ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants