Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): add shell linter - Differential ShellCheck #771

Closed
wants to merge 2 commits into from
Closed

Conversation

jamacku
Copy link

@jamacku jamacku commented Apr 21, 2024

Description

Addition of a new job in CI workflow that scans all shell scripts in the repo using ShellCheck and reports only newly added defects.

Differential ShellCheck is a GitHub action that performs differential ShellCheck scans on shell scripts changed via PR and reports results directly in PR.

It produces reports in SARIF format. GitHub understands this format and is able to display it nicely as a PR comment, and on the Files Changed tab, please see below.

Documentation is available at @redhat-plumbers-in-action/differential-shellcheck.

Screenshots

image

image

Copy link

Click here to review and test in web IDE: Contribute

Copy link

⚡️ Deploying PR Preview...

@aireilly
Copy link
Member

Thanks for the PR. Any particular reason why you are targeting this repo with this update? You've not contributed here before.

@jamacku
Copy link
Author

jamacku commented Apr 22, 2024

I just came across your org and this repo, and I noticed that you have some shell scripts and don't run ShellCheck in your CI.

@aireilly aireilly requested a review from themr0c April 22, 2024 12:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@themr0c
Copy link
Collaborator

themr0c commented Jun 10, 2024

@aireilly
Copy link
Member

Not required

@aireilly aireilly closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants