Fix code scanning issues #978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves 30 occurrences of:
```ts
require(path.join(__dirname), './relative-path'))
```
By replacing them with the equivalent:
```
require('./relative-path')
```
remcohaszing
force-pushed
the
fix-security-reports
branch
from
228e879
to
6800df8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
remcohaszing
commented
Jun 7, 2024
| @@ -786,7 +786,7 @@ describe('Auto Completion Tests', () => { | |||
| }); | |||
|
|
|||
| it('Insert required attributes at correct level', (done) => { | |||
| const schema = require(path.join(__dirname, './fixtures/testRequiredProperties.json')); | |||
| const schema = require('./fixtures/testRequiredProperties.json'); | |||
There was a problem hiding this comment.
Apparently this trades one code scanning alert for another, though the new one is not as bad as the old one.
I do agree with the new failed checks. The proper solution would be to write this at the top of the file:
import schema = require('./fixtures/testRequiredProperties.json');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This resolves 30 occurrences of:
By replacing them with the equivalent:
What issues does this PR fix or reference?
30 code scanning reports on my fork, that I’m sure are also reported on the original repository, though I can’t see them.
Is it tested? How?
npm test