-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitlabCI Support #973
Open
CelianR
wants to merge
20
commits into
redhat-developer:main
Choose a base branch
from
CelianR:celianr/gitlab-jump-to-definition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GitlabCI Support #973
CelianR
wants to merge
20
commits into
redhat-developer:main
from
CelianR:celianr/gitlab-jump-to-definition
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles for !reference and extends
This would be suuuuper useful ! |
Hi @msivasubramaniaan 👋 Do you have any feedback about this PR ? Tell me how you find this work / if some changes are necessary in order to be merged, this would be a great addition to the LSP in my opinion ! |
CelianR
force-pushed
the
celianr/gitlab-jump-to-definition
branch
from
October 22, 2024 12:31
5b4a55d
to
35f3a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
This references the GitlabCI Support issue : #972
Is it tested? How?
Tested on VsCode (vscode-yaml extension)
Details
Changelog
gitlabci.enabled
/gitlabci.codelensEnabled
option!reference
tags are not unknown ifgitlabci.enabled
optionextends
nodes!reference
tags (recursive: multiple definitions will be found if a job extends a job extending another job)needs
tagsinclude
nodesgitlabci.codelensEnabled
option) which go to references to each job (used within needs and extends)Screenshots
Go to includes (ctrl click on vscode)
Show / go to definitions for
needs
/!reference
(ctrl hover / ctrl click on vscode)Show job hierarchy with mouse hover
Show / go to definitions with
extends
(shows the recursive hierarchy)Show usages code lens (when clicked)