Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitlabCI Support #973

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

CelianR
Copy link

@CelianR CelianR commented May 23, 2024

What issues does this PR fix or reference?

This references the GitlabCI Support issue : #972

Is it tested? How?

Tested on VsCode (vscode-yaml extension)

Details

Changelog

  • Added gitlabci.enabled / gitlabci.codelensEnabled option
  • !reference tags are not unknown if gitlabci.enabled option
  • Go-to definition for:
    • extends nodes
    • !reference tags (recursive: multiple definitions will be found if a job extends a job extending another job)
    • needs tags
    • include nodes
  • Show job hierarchy with mouse hover
  • All files within all workspaces are parsed (for cross file references)
  • “Show usages” code lens (with gitlabci.codelensEnabled option) which go to references to each job (used within needs and extends)

Screenshots

Screenshot 2024-05-23 at 13 08 52

Go to includes (ctrl click on vscode)

Screenshot 2024-05-23 at 13 09 15

Screenshot 2024-05-23 at 13 09 27

Show / go to definitions for needs / !reference (ctrl hover / ctrl click on vscode)

Screenshot 2024-05-23 at 13 09 45

Show job hierarchy with mouse hover

Screenshot 2024-05-23 at 13 09 56

Screenshot 2024-05-23 at 13 10 16

Show / go to definitions with extends (shows the recursive hierarchy)

Screenshot 2024-05-23 at 13 10 31

Show usages code lens (when clicked)

@amenasria
Copy link

This would be suuuuper useful !

@coveralls
Copy link

coveralls commented May 28, 2024

Coverage Status

coverage: 81.746% (-2.4%) from 84.174%
when pulling 991f483 on CelianR:celianr/gitlab-jump-to-definition
into 0871dc1 on redhat-developer:main.

@CelianR
Copy link
Author

CelianR commented Jun 11, 2024

Hi @msivasubramaniaan 👋 Do you have any feedback about this PR ? Tell me how you find this work / if some changes are necessary in order to be merged, this would be a great addition to the LSP in my opinion !

@CelianR CelianR force-pushed the celianr/gitlab-jump-to-definition branch from 5b4a55d to 35f3a6f Compare October 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants