Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multipple breakpoints to editor #905

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add multipple breakpoints to editor #905

merged 1 commit into from
Oct 3, 2023

Conversation

unsortedhashsets
Copy link
Contributor

Just an idea to hold info about toggled breakpoints in the text editor object attribute

Will be glad to read feedback and better ideas

fix #904

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@unsortedhashsets unsortedhashsets marked this pull request as draft August 11, 2023 10:13
@unsortedhashsets unsortedhashsets added enhancement New feature or request help-wanted Extra attention is needed question Further information is requested do-not-merge and removed do-not-merge/work-in-progress labels Aug 11, 2023
@djelinek djelinek marked this pull request as ready for review September 15, 2023 07:50
@djelinek djelinek force-pushed the 904 branch 2 times, most recently from 40b95a8 to 71da122 Compare September 25, 2023 11:26
@djelinek djelinek force-pushed the 904 branch 2 times, most recently from 092b28b to 0ae559d Compare October 3, 2023 16:19
@djelinek djelinek self-requested a review October 3, 2023 18:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djelinek djelinek merged commit 81c7f87 into redhat-developer:main Oct 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request help-wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Editor does not support multiple breakpoints
2 participants
@unsortedhashsets @djelinek