Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs-build): Do not use unsupported special chars for artifacts name in NodeJS workflow #1189

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

djelinek
Copy link
Collaborator

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

… name in NodeJS workflow

Signed-off-by: Dominik Jelinek <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek changed the title build: Use 'lts' placeholder in NodeJS workflow matrix fix(nodejs-build): Do not use unsupported special chars for artifacts name in NodeJS workflow Mar 19, 2024
@djelinek djelinek marked this pull request as ready for review March 19, 2024 12:29
@djelinek djelinek merged commit c7ffe5b into redhat-developer:main Mar 19, 2024
11 checks passed
@djelinek djelinek added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant