Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(vscode): Bump 'max' placeholder to use VS Code 1.87.0 #1167

Merged
merged 11 commits into from
Mar 20, 2024
Merged

build(vscode): Bump 'max' placeholder to use VS Code 1.87.0 #1167

merged 11 commits into from
Mar 20, 2024

Conversation

djelinek
Copy link
Collaborator

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek force-pushed the vscode-1.87.0 branch 2 times, most recently from c26ac9e to 8736ff6 Compare March 4, 2024 23:43
@djelinek djelinek linked an issue Mar 5, 2024 that may be closed by this pull request
[🚀 Request] Support for VS Code 1.87.0 #1169
Closed
@djelinek djelinek added the enhancement New feature or request label Mar 5, 2024
@djelinek djelinek force-pushed the vscode-1.87.0 branch 4 times, most recently from ef21d1a to 85df5bc Compare March 8, 2024 10:30
djelinek added 10 commits March 19, 2024 16:14
@djelinek
build(vscode): Bump 'max' placeholder to use VS Code 1.87.2
9deeaec 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix BottomBarPanel tests for 1.87.0
0e1da79 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix SettingsEditor tests for 1.87.0
b42cb0b 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix TextEditor tests for 1.87.0
7ca9513 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix Notification tests for VS Code 1.87.0
48b6a02 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix ScmView tests for VS Code 1.87.0
5eefa0c 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix SideBarView tests for VS Code 1.87.0
c523d38 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix Debug tests for VS Code 1.87.0
55d7998 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix ModialDialog tests for VS Code 1.87.0
1b19e8d
@djelinek
chore: Mention limitations for VS Code 1.87+ in known issues
36747b8 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek djelinek force-pushed the vscode-1.87.0 branch 2 times, most recently from 07b2af5 to 743d41a Compare March 20, 2024 12:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek linked an issue Mar 20, 2024 that may be closed by this pull request
[🚫 Bug] Dialog Pushbutton Not Working #1195
Closed
@djelinek djelinek modified the milestone: NEXT Mar 20, 2024
@djelinek djelinek marked this pull request as ready for review March 20, 2024 13:21
@djelinek djelinek merged commit 80f3d1b into redhat-developer:main Mar 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] Dialog Pushbutton Not Working [🚀 Request] Support for VS Code 1.87.0
1 participant
@djelinek