Use latest 18.x #1144
Merged
Use latest 18.x #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
commented
Feb 22, 2024
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| |NodeJS|Visual Studio Code|Operating System| | |||
| |--|--|--| | |||
| |<table style="text-align:center;"> <tr><th>16.x.x</th><th>18.x.x</th></tr><tr><td>✅</td><td>⚠️ <=18.15.x</td></tr> </table>| <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.84.2</td><td>1.85.2</td><td>1.86.2</td></tr> </table>| <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅</td><td>✅</td><td>⚠️ [Known Issues](KNOWN_ISSUES.md#macos-known-limitations-of-native-objects)</td></tr> </table>| | |||
| |<table style="text-align:center;"> <tr><th>16.x.x</th><th>18.x.x</th></tr><tr><td>✅</td><td>✅</td></tr> </table>| <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.84.2</td><td>1.85.2</td><td>1.86.2</td></tr> </table>| <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅</td><td>✅</td><td>⚠️ [Known Issues](KNOWN_ISSUES.md#macos-known-limitations-of-native-objects)</td></tr> </table>| | |||
There was a problem hiding this comment.
note for the future: I think we can remove the 16.x which is EOL and we habe no automated tests. Maybe we could add 20 and 21 and marking them as (no automated test), like best-effort and no known issue
apupier
force-pushed
the
975-fix_with_18.x
branch
from
6f608ba to
67f186b
Compare
apupier
commented
Feb 22, 2024
djelinek
reviewed
Feb 22, 2024
djelinek
reviewed
Feb 22, 2024
it requires to get rid of unzipper which was corrupting the extracted binary of chromedriver on Linux and VS Code on Windows with Node 18.15+ fixes redhat-developer#975 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
975-fix_with_18.x
branch
from
67f186b to
8f11a91
Compare
|
djelinek
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it requires to get rid of unzipper which was corrupting the extracted binary of chromedriver on Linux and VS Code on Windows with Node 18.15+
fixes #975
Before submitting your PR, please review the following checklist:
Before merging the PR:
mainbranch is green.