Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moveCursor fails on file with tabs #1007

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: moveCursor fails on file with tabs #1007

merged 1 commit into from
Jul 30, 2024

Conversation

djelinek
Copy link
Collaborator

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek force-pushed the issue-931 branch 29 times, most recently from 82a7d07 to 2ebc638 Compare November 23, 2023 11:30
@djelinek djelinek changed the title issue-931: moveCursor fails on file with tabs fix: moveCursor fails on file with tabs Jun 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek force-pushed the issue-931 branch 7 times, most recently from 6cdaf56 to 3531461 Compare July 29, 2024 14:23
@djelinek djelinek force-pushed the issue-931 branch 13 times, most recently from 8f63718 to 8638578 Compare July 30, 2024 11:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek marked this pull request as ready for review July 30, 2024 14:45
@djelinek djelinek merged commit 7c67114 into redhat-developer:main Jul 30, 2024
12 checks passed
lgrossma pushed a commit to lgrossma/vscode-extension-tester that referenced this pull request Aug 1, 2024
@djelinek
fix: moveCursor fails on file with tabs (redhat-developer#1007)
3e42ab9 
Signed-off-by: Dominik Jelinek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbanfly urbanfly urbanfly left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] moveCursor fails on file with tabs
2 participants
@djelinek @urbanfly