Skip to content

Commit

Permalink
Fix regression Terminal View bug in VS Code 1.67.2 (#770)
Browse files Browse the repository at this point in the history
Signed-off-by: Dominik Jelinek <[email protected]>
  • Loading branch information
djelinek authored May 16, 2023
1 parent a5e58e2 commit b14f3ac
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:
version: max
- os: windows-latest
version: max
- os: windows-latest
version: 1.67.2
fail-fast: false

env:
Expand Down
2 changes: 1 addition & 1 deletion page-objects/src/components/bottomBar/Views.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export class TerminalView extends ChannelView {
const workbench = new Workbench();
await workbench.executeCommand('terminal select all');
await workbench.getDriver().sleep(500);
if(process.platform !== 'darwin') {
if(process.platform === 'linux') {
const menu = await this.openContextMenu();
await workbench.getDriver().sleep(500);
await menu.select('Copy');
Expand Down
2 changes: 1 addition & 1 deletion test/test-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"compile": "rimraf out && tsc -p ./ && npm run lint",
"lint": "eslint src --ext .ts",
"watch": "tsc -watch -p ./",
"ui-test": "extest setup-and-run './out/src/test/cli/order-3-test.js' './out/src/test/cli/order-2-test.js' './out/src/test/cli/order-1-test.js' './out/src/test/**/customView*test.js' -u -i -r . -e ./test-extensions",
"ui-test": "extest setup-and-run './out/src/test/cli/order-3-test.js' './out/src/test/cli/order-2-test.js' './out/src/test/cli/order-1-test.js' './out/src/test/**/customView*test.js' './out/src/test/**/views*test.js' -u -i -r . -e ./test-extensions",
"ci-test": "extest setup-and-run './out/src/test/cli/order-3-test.js' './out/src/test/cli/order-2-test.js' './out/src/test/cli/order-1-test.js' './out/src/test/**/*test.js' -u -i -r . -e ./test-extensions"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion test/test-project/src/test/bottomBar/views-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ describe('Output View/Text Views', function () {

it('executeCommand works', async function () {
const command = `${process.platform === 'win32' ? 'start-sleep -s' : 'sleep'} 2`;
await terminal.executeCommand(command, 3000);
await terminal.executeCommand(command, 5000);
});

it('newTerminal opens a new term channel', async function () {
Expand Down

0 comments on commit b14f3ac

Please sign in to comment.