Skip to content

Commit

Permalink
Bump 'max' placeholder to latest vscode 1.81.0 (#895)
Browse files Browse the repository at this point in the history
Signed-off-by: Dominik Jelinek <[email protected]>
  • Loading branch information
djelinek authored Aug 4, 2023
1 parent 68fa9fe commit 637c2c9
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
version: [ min, 1.79.2, max ]
version: [ min, 1.80.2, max ]
fail-fast: false

env:
Expand Down
4 changes: 2 additions & 2 deletions src/extester.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export const DEFAULT_SETUP_OPTIONS = {
installDependencies: false
}

export const VSCODE_VERSION_MIN = '1.78.2';
export const VSCODE_VERSION_MAX = '1.80.2';
export const VSCODE_VERSION_MIN = '1.79.2';
export const VSCODE_VERSION_MAX = '1.81.0';

/**
* VSCode Extension Tester
Expand Down
21 changes: 11 additions & 10 deletions test/test-project/src/test/bottomBar/bottomBarPanel-test.ts
Original file line number Diff line number Diff line change
@@ -1,31 +1,32 @@
import { expect } from 'chai';
import { BottomBarPanel, WebElement, Workbench, ViewControl, ActivityBar } from 'vscode-extension-tester';

describe('BottomBarPanel', () => {
describe('BottomBarPanel', function () {
let panel: BottomBarPanel;

before(async () => {
before(async function () {
panel = new BottomBarPanel();
await (await new Workbench().openNotificationsCenter()).clearAllNotifications();
await (await new ActivityBar().getViewControl('Explorer') as ViewControl).openView();
});

after(async () => {
after(async function () {
await panel.toggle(false);
});

it('can be toggled open', async () => {
it('can be toggled open', async function () {
await panel.toggle(true);
expect(await panel.isDisplayed()).is.true;
});

it('can be toggled closed', async () => {
it('can be toggled closed', async function () {
await panel.toggle(true);
await panel.toggle(false);
expect(await panel.isDisplayed()).is.false;
});

it('can be maximized and restored', async () => {
it('can be maximized and restored', async function () {
this.timeout(20000);
await panel.toggle(true);
const initHeight = await getHeight(panel);

Expand All @@ -39,22 +40,22 @@ describe('BottomBarPanel', () => {
expect(initHeight).equals(restoredHeight);
});

it('can open problems view', async () => {
it('can open problems view', async function () {
const view = await panel.openProblemsView();
expect(await view.isDisplayed()).is.true;
});

it('can open output view', async () => {
it('can open output view', async function () {
const view = await panel.openOutputView();
expect(await view.isDisplayed()).is.true;
});

it('can open debug console view', async () => {
it('can open debug console view', async function () {
const view = await panel.openDebugConsoleView();
expect(await view.isDisplayed()).is.true;
});

it('can open terminal view', async () => {
it('can open terminal view', async function () {
const view = await panel.openTerminalView();
expect(await view.isDisplayed()).is.true;
});
Expand Down
1 change: 1 addition & 0 deletions test/test-project/src/test/editor/textEditor-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ describe('TextEditor', function () {
});

it('clicking triggers the lens command', async function () {
this.timeout(20000);
const lens = await editor.getCodeLens(2);
await lens.click();
await lens.getDriver().sleep(1000);
Expand Down

0 comments on commit 637c2c9

Please sign in to comment.