Skip to content

Commit

Permalink
feat: bump vscode-max version from 1.90.1 to 1.91.1 (#1400)
Browse files Browse the repository at this point in the history
Signed-off-by: Dominik Jelinek <[email protected]>
  • Loading branch information
djelinek authored Jul 15, 2024
1 parent 1f875f0 commit 28fab3d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

| NodeJS | Visual Studio Code | Operating System |
| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| <table style="text-align:center;"> <tr><th>18.x.x</th><th>20.x.x</th><th>LTS</th><th>Latest</th></tr><tr><td>✅</td><td>✅</td><td>❓</td><td>❓</td></tr><tr><td colspan="4">❓ Best-effort</td></tr> </table> | <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.88.x</td><td>1.89.x</td><td>1.90.x</td></tr> </table> | <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅</td><td>✅</td><td>⚠️</td></tr><tr><td colspan="3">⚠️ [Known Issues](KNOWN_ISSUES.md#macos-known-limitations-of-native-objects)</td></tr> </table> |
| <table style="text-align:center;"> <tr><th>18.x.x</th><th>20.x.x</th><th>LTS</th><th>Latest</th></tr><tr><td>✅</td><td>✅</td><td>❓</td><td>❓</td></tr><tr><td colspan="4">❓ Best-effort</td></tr> </table> | <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.89.x</td><td>1.90.x</td><td>1.91.x</td></tr> </table> | <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅</td><td>✅</td><td>⚠️</td></tr><tr><td colspan="3">⚠️ [Known Issues](KNOWN_ISSUES.md#macos-known-limitations-of-native-objects)</td></tr> </table> |

#### NodeJS Support Policy

Expand Down
4 changes: 2 additions & 2 deletions packages/extester/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"ui-test"
],
"supportedVersions": {
"vscode-min": "1.88.1",
"vscode-max": "1.90.2",
"vscode-min": "1.89.1",
"vscode-max": "1.91.1",
"nodejs": "20"
},
"dependencies": {
Expand Down
5 changes: 3 additions & 2 deletions tests/test-project/src/test/debug/debug.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import * as path from 'path';
import { expect } from 'chai';

const line = 7;
const varSub = VSBrowser.instance.version >= '1.91.0' ? 'num =' : 'num:';

describe('Debugging', function () {
process.env.NODE = process.execPath;
Expand Down Expand Up @@ -227,7 +228,7 @@ describe('Debugging', function () {

it('VariableSectionItem.getVariableName', async function () {
const item = await getNumVariable(view, this.timeout() - 2000);
expect(await item?.getVariableName()).equals('num:');
expect(await item?.getVariableName()).equals(varSub);
});

it('VariableSectionItem.getVariableValue', async function () {
Expand Down Expand Up @@ -322,7 +323,7 @@ async function getNumVariable(view: DebugView, timeout: number) {
try {
const variablesSection = await view.getVariablesSection();
await variablesSection?.openItem('Local');
return await variablesSection.findItem('num:');
return await variablesSection.findItem(varSub);
} catch (e) {
if (
e instanceof error.StaleElementReferenceError ||
Expand Down

0 comments on commit 28fab3d

Please sign in to comment.