chore(deps): make sure Renovate updates for OpenShift, Ginkgo and Gomega modules are disabled #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mega libs These modules require Go 1.22+, which we do not support at the moment. Also, the previous exclusion rule got `github.com/openshift` appeared to not be working as expected, probably because of the `matchUpdateTypes` field, which did not seem to handle pseudo-versions from commits in that repo.
gazarenkov
approved these changes
Oct 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gazarenkov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rm3l
deleted the
disable_renovate_updates_for_openshift-api_and_ginkgo_and_gomega
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were getting a lot of noise from dependency updates for the following modules, which all require Go 1.22+ (not yet supported at the moment).
We usually end up manually closing the corresponding PRs, but new ones would be created as soon as there were new updates available.
The ones from
github.com/openshift/apiwere creating most of the noise because we are depending on a pseudo-version mapped to a commit. So (from my observations) a new update PR would be created anytime there is a new commit in https://github.com/openshift/api/commits/master/.Which issue(s) does this PR fix or relate to
—
PR acceptance criteria
rhdh-operator.clusterserviceversion.yamlfile accordinglyHow to test changes / Special notes to the reviewer
Renovate Config Validator job passed: https://github.com/redhat-developer/rhdh-operator/actions/runs/11177943170/job/31074500161?pr=305