Skip to content

Commit

Permalink
docs: add note in CRD that using Routes with external certificates in…
Browse files Browse the repository at this point in the history
… TLS Secrets is Technical Preview in OCP [RHDHBUGS-45] (#413)

* Add note in CRD that Routes with external certificates in TLS Secrets is Tech Preview in OCP

* Regenerate bundle manifests
  • Loading branch information
rm3l authored Jul 26, 2024
1 parent bb549e4 commit 00f5555
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 5 deletions.
2 changes: 2 additions & 0 deletions api/v1alpha1/backstage_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@ type TLS struct {
// chain. Do not include a CA certificate. The secret referenced should
// be present in the same namespace as that of the Route.
// Forbidden when `certificate` is set.
// Note that securing Routes with external certificates in TLS secrets is a Technology Preview feature in OpenShift,
// and requires enabling the `RouteExternalCertificate` OpenShift Feature Gate and might not be functionally complete.
// +optional
ExternalCertificateSecretName string `json:"externalCertificateSecretName,omitempty"`

Expand Down
2 changes: 2 additions & 0 deletions api/v1alpha2/backstage_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,8 @@ type TLS struct {
// chain. Do not include a CA certificate. The secret referenced should
// be present in the same namespace as that of the Route.
// Forbidden when `certificate` is set.
// Note that securing Routes with external certificates in TLS secrets is a Technology Preview feature in OpenShift,
// and requires enabling the `RouteExternalCertificate` OpenShift Feature Gate and might not be functionally complete.
// +optional
ExternalCertificateSecretName string `json:"externalCertificateSecretName,omitempty"`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
}
]
capabilities: Seamless Upgrades
createdAt: "2024-07-16T20:47:15Z"
createdAt: "2024-07-25T11:50:13Z"
operatorframework.io/suggested-namespace: backstage-system
operators.operatorframework.io/builder: operator-sdk-v1.33.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
Expand Down
12 changes: 10 additions & 2 deletions bundle/manifests/rhdh.redhat.com_backstages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@ spec:
serving certificate, not a certificate chain. Do not
include a CA certificate. The secret referenced should
be present in the same namespace as that of the Route.
Forbidden when `certificate` is set.
Forbidden when `certificate` is set. Note that securing
Routes with external certificates in TLS secrets is
a Technology Preview feature in OpenShift, and requires
enabling the `RouteExternalCertificate` OpenShift Feature
Gate and might not be functionally complete.
type: string
key:
description: key provides key file contents
Expand Down Expand Up @@ -622,7 +626,11 @@ spec:
serving certificate, not a certificate chain. Do not
include a CA certificate. The secret referenced should
be present in the same namespace as that of the Route.
Forbidden when `certificate` is set.
Forbidden when `certificate` is set. Note that securing
Routes with external certificates in TLS secrets is
a Technology Preview feature in OpenShift, and requires
enabling the `RouteExternalCertificate` OpenShift Feature
Gate and might not be functionally complete.
type: string
key:
description: key provides key file contents
Expand Down
12 changes: 10 additions & 2 deletions config/crd/bases/rhdh.redhat.com_backstages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,11 @@ spec:
serving certificate, not a certificate chain. Do not
include a CA certificate. The secret referenced should
be present in the same namespace as that of the Route.
Forbidden when `certificate` is set.
Forbidden when `certificate` is set. Note that securing
Routes with external certificates in TLS secrets is
a Technology Preview feature in OpenShift, and requires
enabling the `RouteExternalCertificate` OpenShift Feature
Gate and might not be functionally complete.
type: string
key:
description: key provides key file contents
Expand Down Expand Up @@ -623,7 +627,11 @@ spec:
serving certificate, not a certificate chain. Do not
include a CA certificate. The secret referenced should
be present in the same namespace as that of the Route.
Forbidden when `certificate` is set.
Forbidden when `certificate` is set. Note that securing
Routes with external certificates in TLS secrets is
a Technology Preview feature in OpenShift, and requires
enabling the `RouteExternalCertificate` OpenShift Feature
Gate and might not be functionally complete.
type: string
key:
description: key provides key file contents
Expand Down

0 comments on commit 00f5555

Please sign in to comment.