-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volumeMount for dynamic-plugins-registry-auth #41
Add volumeMount for dynamic-plugins-registry-auth #41
Conversation
a81afa0
to
d6e9e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the error in CI, it looks like you need to bump the chart version: https://github.com/redhat-developer/rhdh-chart/actions/runs/10466892802/job/28984592226?pr=41#step:7:38
thanks, I wanted to wait until #40 get's merged and then bump the version again :) |
86120cb
to
f799d66
Compare
f799d66
to
533fa40
Compare
Quality Gate passedIssues Measures |
changed the defaultMode to 416, thanks for pointing it out on redhat-developer/rhdh-operator#102 (comment) |
/retest |
From the CI logs, it looks like the
I get the same error on the To fix this, I think we should switch to the |
@rm3l interestingly https://github.com/redhat-developer/rhdh-chart/actions/runs/10355552516/job/28663454790 did work for the |
/retest |
Yeah, I noticed that as well. But that run was 2 weeks ago, and the
You're right. Maybe the test should be explicit about the tag it is using and use |
let's wait for @nickboldt to chime in. The last I would also expect |
Something has gone horribly wrong with https://quay.io/repository/rhdh/rhdh-hub-rhel9?tab=tags as 1.1 should NOT link to latest (that is reserved for the current stable release and its z-stream updates next meanwhile points to builds from main (1.3 currently) once we branch for feature freeze, after a couple days the latest tag will move to 1.3 and next will move to 1.4. I've fixed the borked :latest tags like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the borked :latest tags like this:
skopeo --insecure-policy copy --all docker://quay.io/rhdh/rhdh-hub-rhel9:{1.2,latest} skopeo --insecure-policy copy --all docker://quay.io/rhdh/rhdh-rhel9-operator:{1.2,latest} skopeo --insecure-policy copy --all docker://quay.io/rhdh/rhdh-operator-bundle:{1.2,latest}
Thanks! CI passes with the fixed latest
tag.
/lgtm
For secure container registry we need a
auth.json
file that contains auth tokens. The file is stored as a secret likeIt is then picked up by
skopeo
during the dynamic plugin install process.Accompanying PR for dynamic plugins:
janus-idp/backstage-showcase#1479