add RN text for 1.2.5 (RHIDP-4218) #592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themr0c
approved these changes
Oct 7, 2024
nickboldt
commented
Oct 7, 2024
|
Moving back to draft mode, waiting to get these 2 last CVEs fixed so we can uncomment them. |
|
TODO: refactor to use similar filenames as in https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/596/files |
Signed-off-by: Nick Boldt <[email protected]> dedupe and add note about source of the freshmaker/RPM updates Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]> switch to content from 1.2.5, including support for blank/comment lines Signed-off-by: Nick Boldt <[email protected]> remove embedded content for 1.2.5 Signed-off-by: Nick Boldt <[email protected]> adjust spacing Signed-off-by: Nick Boldt <[email protected]> add notes about how the script changes in 1.3 version Signed-off-by: Nick Boldt <[email protected]> wrong indent Signed-off-by: Nick Boldt <[email protected]>
|
|
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-592/ @ 10/11/24 15:07:52 |
Fortune-Ndlovu
approved these changes
Oct 10, 2024
kim-tsao
reviewed
Oct 10, 2024
…2.5.txt Co-authored-by: Kim Tsao <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick...
What does this PR do?
add RN text for 1.2.5
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/RHIDP-4218
How to test this PR?
run the script, see the output, paste into the specified file.
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.