Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-1583: Add details for favicon customization #280

Closed
wants to merge 1 commit into from

Conversation

abrennan89
Copy link
Member

@abrennan89 abrennan89 commented Jun 12, 2024

Versions:
1.2+

Jira link:

Preview link:

Reviews:

Notes
There is a separate PR for 1.1.x that implements the changes from this PR as well as the improvements from #260 but without the sidebar logo width, which only applies for 1.2+.

1.1.x PR: #281

@rhdh-bot
Copy link
Collaborator

@rhdh-bot
Copy link
Collaborator

@invincibleJai
Copy link

Thanks @abrennan89

Favicon customization is not working as expected, we have a ticket for this here janus-idp/backstage-showcase#777

So I don't think we should be capturing this as part of docs and can add it in known issues may be.

@nickboldt
Copy link
Member

nickboldt commented Jun 20, 2024

add it in known issues

@invincibleJai is this something we're looking to fix in 1.3? If so then yeah, a KI makes sense; but if it's not really on the radar to fix it, then do we want to expose a KI that we'l have to carry forward for a few releases?

@abrennan89
Copy link
Member Author

Closing PR since this functionality currently isn't working

@abrennan89 abrennan89 closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants