Remove code that overrides the search bar background color #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New package is available at: |
christoph-jerolimov
force-pushed
the
remove-overriding-searchbar
branch
from
221c581
to
7528bf1
Compare
|
New package is available at: |
christoph-jerolimov
force-pushed
the
remove-overriding-searchbar
branch
from
7528bf1
to
dda2a45
Compare
ciiay
approved these changes
Sep 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciiay, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christoph-jerolimov
force-pushed
the
remove-overriding-searchbar
branch
from
dda2a45
to
d9d34b9
Compare
|
New changes are detected. LGTM label has been removed. |
|
New package is available at: |
|
I just rebased the PR to check if the npm (preview) package was build now correctly. |
christoph-jerolimov
merged commit 5adf42f
into
redhat-developer:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style is now already added in the home page
SearchBarcomponent: https://github.com/janus-idp/backstage-showcase/blob/main/plugins/dynamic-home-page/src/components/SearchBar.tsx#L9-L16In that component, we might use a better-existing theme prop, then hard coded values. But I don't think we need a "search border" color anymore.
/cc @ciiay