e2e tests added #210
Open
e2e tests added #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xbabalov <[email protected]>
Signed-off-by: xbabalov <[email protected]>
jeffmaury
requested changes
Oct 10, 2024
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@kubernetes/client-node": "^0.22.0", | ||
| "@podman-desktop/api": "^1.12.0", | ||
| "fs-extra": "^11.2.0", | ||
| "got": "^14.4.2", | ||
| "js-yaml": "^4.1.0" | ||
| "js-yaml": "^4.1.0", | ||
| "node-fetch": "^2.6.1" |
There was a problem hiding this comment.
Should be in devDependencies ?
Signed-off-by: xbabalov <[email protected]>
Signed-off-by: xbabalov <[email protected]>
…x-ext into e2e-tests
Signed-off-by: xbabalov <[email protected]>
Signed-off-by: xbabalov <[email protected]>
…x-ext into e2e-tests
Signed-off-by: xbabalov <[email protected]>
odockal
requested changes
Oct 15, 2024
xbabalov
force-pushed
the
e2e-tests
branch
3 times, most recently
from
ae64397
to
bcdace9
Compare
Signed-off-by: xbabalov <[email protected]>
odockal
approved these changes
Oct 16, 2024
jeffmaury
requested changes
Oct 16, 2024
|
@jeffmaury @xbabalov First we need to switch to ES modules and then we could merge this PR. I will open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added e2e tests that cover extension installation and handling.
Issues: #199 and #201