Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sandbox connection status #17

Conversation

dgolovin
Copy link
Collaborator

Update connection status every 2 seconds.

@dgolovin dgolovin requested a review from a team as a code owner April 28, 2023 01:44
@dgolovin dgolovin requested a review from jeffmaury April 28, 2023 01:44
@dgolovin
Copy link
Collaborator Author

@benoitf How do we usually deal with dependency cycles? The only way I found is intercept warnings and cancel it.

@benoitf
Copy link
Collaborator

benoitf commented Apr 28, 2023

@dgolovin usually we avoid these situations by refactoring the code

@dgolovin
Copy link
Collaborator Author

@benoitf well, I have only one file in the extension, but whenever I use Kubeconfig from @kubernetes/client-node I get this locally and that fails the build on macOS.

% yarn build
yarn run v1.22.19
warning [email protected]: The engine "podman-desktop" appears to be invalid.
$ rollup --bundleConfigAsCjs --config rollup.config.js --compact --environment BUILD:production  && node ./scripts/build.js

src/extension.ts → dist...
(!) Circular dependencies
node_modules/sshpk/lib/key.js -> node_modules/sshpk/lib/fingerprint.js -> node_modules/sshpk/lib/key.js
node_modules/sshpk/lib/fingerprint.js -> node_modules/sshpk/lib/private-key.js -> node_modules/sshpk/lib/fingerprint.js
node_modules/sshpk/lib/private-key.js -> node_modules/sshpk/lib/signature.js -> node_modules/sshpk/lib/utils.js -> node_modules/sshpk/lib/private-key.js
...and 89 more
created dist in 6.4s
✨  Done in 25.59s.

Will try to apply what is suggested here TritonDataCenter/node-sshpk#42

@dgolovin
Copy link
Collaborator Author

This seems to happen only to external dependencies, because in case of extensions in podman-desktop repository it is not present in extension's node_modules folder.

@benoitf
Copy link
Collaborator

benoitf commented Apr 28, 2023

you could use vite instead of roll-up as in the compose extension

@dgolovin dgolovin force-pushed the i11-monitor-update-sandbox-connections-state branch from c95ccb6 to 579d6c7 Compare April 28, 2023 23:08
@dgolovin dgolovin merged commit 8e01dec into redhat-developer:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants