Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation of integration tests for downstream CI #97

Merged

Conversation

prabinovRedhat
Copy link
Collaborator

@nirarg
Copy link
Contributor

nirarg commented Sep 11, 2024

Can you please elaborate why adding the azure_ops prefix is required?
As far as I understand, the test name convention until now was test_<role-name>
Adding also the azure_ops in the beginning might make it too complicated

@prabinovRedhat
Copy link
Collaborator Author

prabinovRedhat commented Sep 12, 2024

Can you please elaborate why adding the azure_ops prefix is required?

Sure, I can :)
The test naming convention in the CI is to use the prefix (the name of the collection) at the beginning, before the actual test name. We’ve renamed all our tests in VMware and ServiceNow collections to follow this convention, so I’d like to apply the same for Azure as well. Let me know if you agree
@nirarg

@nirarg nirarg merged commit bca6d07 into redhat-cop:main Sep 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants