Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled gosec and fixed security issue #370

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

aneeshkp
Copy link
Member

@aneeshkp aneeshkp commented Nov 8, 2024

Enabled gosec and fixed three sec issues

  1. Linter: gosec, Rule: G306 - Poor file permissions used
    [Key file permissions are not correct, should be 600 or 660]
  2. G304: Potential file inclusion via variable
  3. Use of net/http serve function that has no support for setting timeouts (gosec) err := http.ListenAndServe(address, mux)

Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7bbec54 into redhat-cne:main Nov 8, 2024
5 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.18.0-202411081938.p0.g7bbec54.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants