OCPBUGS-39218: fix double / in ResourceAddress #353
Conversation
|
@jzding: This pull request references Jira Issue OCPBUGS-39218, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -260,7 +260,10 @@ func (p *PTPEventManager) GetPTPEventsData(state ptp.SyncState, ptpOffset int64, | |||
| return nil | |||
| } | |||
| // /cluster/xyz/ptp/CLOCK_REALTIME this is not address the event is published to | |||
| eventSource := fmt.Sprintf(p.resourcePrefix, p.nodeName, fmt.Sprintf("/%s", source)) | |||
| if !strings.HasPrefix(source, "/") { | |||
There was a problem hiding this comment.
use path.join
eventSource := fmt.Sprintf("%s", path.Join(p.resourcePrefix, p.nodeName, source))
There was a problem hiding this comment.
can't simply use path.Join, this is what came out.
/cluster/node/%s%s/cnfdg4.ptp.eng.rdu2.dc.redhat.com/ptp-not-set
added more changes
jzding
force-pushed
the
sync-status-slash
branch
3 times, most recently
from
1e0712d to
05a45db
Compare
Signed-off-by: Jack Ding <[email protected]>
jzding
force-pushed
the
sync-status-slash
branch
from
05a45db to
16ca9bd
Compare
|
/cherry-pick release-4.17 |
|
@jzding: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, jzding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jzding: Jira Issue OCPBUGS-39218: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-39218 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jzding: new pull request created: #355 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cloud-event-proxy |
No description provided.