OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #270

aneeshkp · 2023-11-30T20:51:17Z

No description provided.

openshift-ci-robot · 2023-12-12T18:37:32Z

@aneeshkp: This pull request references Jira Issue OCPBUGS-24595, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aneeshkp · 2023-12-12T18:37:36Z

/jira refresh

openshift-ci-robot · 2023-12-12T18:37:40Z

@aneeshkp: This pull request references Jira Issue OCPBUGS-24595, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jzding · 2023-12-12T21:00:00Z

plugins/ptp_operator/event/event.go

+	return -1, nil
+}
+
+func (dt *DependingClockState) hasMetric() map[string]*PMetric {


shouldn't this return Metric based on specific iface similar to hasClockState?

it is based on dependent type, metrics is common for all interface based on type, so you are checking is there is metrics object already define. You can't register same metrics twice

jzding · 2023-12-12T21:01:06Z

plugins/ptp_operator/event/event.go

+	}
+	return nil
+}
+func (dt *DependingClockState) hasMetricHelp() map[string]string {


same here, should return MetricHelp based on specific iface similar to hasClockState

it is based on dependent type, metrics is common for all interface based on type, so you are checking is there is metrics object already define. You can't register same metrics twice

jzding · 2023-12-12T23:13:56Z

plugins/ptp_operator/event/event.go

@@ -135,22 +176,24 @@ func (p *PTPEventState) UpdateCurrentEventState(c ClockState) ptp.SyncState {
 				"node": clockState.NodeName, "iface": alias}).Set(float64(v))
 		}
 		clockState.Metric = metrics
-		p.DependsOn[c.Process] = clockState
+		p.DependsOn[c.Process] = []*ClockState{clockState}
 	}

 	// if all locked then its locked
 	// if anyone HOLDOVER then holdover
 	// if  anyone FREERUN then freerun


comments not clear. What the currentState should be if DependsOn states are a mix of HOLDVER and FREERUN?

if anyone is HOLDOVER then holdover comment 2

jzding

/lgtm

jzding · 2023-12-14T00:22:58Z

plugins/ptp_operator/metrics/logparser.go

-			if alias == "" {
-				masterAlias, _ = ptp4lCfg.GetUnknownAlias()
+			masterResource := fmt.Sprintf("%s/%s", alias, MasterClockType)
+			if !p.mock { /// to enable unit testing


remove this, the unit test expects the event to be sent.

Signed-off-by: Aneesh Puttur <[email protected]>

jzding

/lgtm

openshift-ci · 2023-12-14T03:38:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [aneeshkp,jzding]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-12-14T03:54:32Z

@aneeshkp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`36c3b28`	link	false	`/test security`
ci/prow/e2e-aws	`36c3b28`	link	false	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aneeshkp · 2023-12-14T11:21:32Z

/jira refresh

openshift-ci-robot · 2023-12-14T11:21:35Z

@aneeshkp: This pull request references Jira Issue OCPBUGS-24595, which is invalid:

expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aneeshkp · 2023-12-14T11:23:22Z

/jira refresh

openshift-ci-robot · 2023-12-14T11:23:28Z

@aneeshkp: This pull request references Jira Issue OCPBUGS-24595, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-12-14T11:23:31Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@aneeshkp: This pull request references Jira Issue OCPBUGS-24595, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.16.0) matches configured target version for branch (4.16.0)

bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aneeshkp · 2023-12-14T11:26:22Z

/test e2e-aws

openshift-ci-robot · 2023-12-14T11:31:45Z

@aneeshkp: Jira Issue OCPBUGS-24595: All pull requests linked via external trackers have merged:

redhat-cne/cloud-event-proxy#270

Jira Issue OCPBUGS-24595 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-14T14:03:20Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cloud-event-proxy-container-v4.16.0-202312141333.p0.g14de4f8.assembly.stream for distgit cloud-event-proxy.
All builds following this will include this PR.

aneeshkp · 2023-12-14T15:48:07Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2023-12-14T15:48:54Z

@aneeshkp: new pull request created: #276

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from jzding and nishant-parekh November 30, 2023 20:51

openshift-ci bot added the approved label Nov 30, 2023

aneeshkp force-pushed the status-matrics-415 branch 3 times, most recently from 6390bd5 to f22a6fa Compare December 12, 2023 18:35

aneeshkp changed the title ~~fix multiple process dpll and nmea metrics~~ OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs Dec 12, 2023

openshift-ci-robot added jira/valid-reference jira/invalid-bug labels Dec 12, 2023

aneeshkp force-pushed the status-matrics-415 branch from f22a6fa to f0dee65 Compare December 12, 2023 18:44

jzding reviewed Dec 12, 2023

View reviewed changes

aneeshkp force-pushed the status-matrics-415 branch 3 times, most recently from 97325a0 to c7daa31 Compare December 13, 2023 17:47

jzding approved these changes Dec 13, 2023

View reviewed changes

openshift-ci bot assigned jzding Dec 13, 2023

openshift-ci bot added the lgtm label Dec 13, 2023

aneeshkp force-pushed the status-matrics-415 branch from c7daa31 to 8340b41 Compare December 13, 2023 22:23

openshift-ci bot removed the lgtm label Dec 13, 2023

aneeshkp force-pushed the status-matrics-415 branch from 8340b41 to bf7a3c3 Compare December 14, 2023 00:06

jzding reviewed Dec 14, 2023

View reviewed changes

aneeshkp force-pushed the status-matrics-415 branch from bf7a3c3 to 41f4a3c Compare December 14, 2023 02:35

fix multipleproces and nmea metrics

36c3b28

Signed-off-by: Aneesh Puttur <[email protected]>

aneeshkp force-pushed the status-matrics-415 branch from 41f4a3c to 36c3b28 Compare December 14, 2023 02:38

jzding approved these changes Dec 14, 2023

View reviewed changes

openshift-ci bot added the lgtm label Dec 14, 2023

openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug labels Dec 14, 2023

openshift-merge-bot bot merged commit 14de4f8 into redhat-cne:main Dec 14, 2023
3 of 4 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 14, 2023

[release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #276

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #270

OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #270

aneeshkp commented Nov 30, 2023

openshift-ci-robot commented Dec 12, 2023

aneeshkp commented Dec 12, 2023

openshift-ci-robot commented Dec 12, 2023

jzding Dec 12, 2023

aneeshkp Dec 13, 2023

jzding Dec 12, 2023

aneeshkp Dec 13, 2023

jzding Dec 12, 2023

aneeshkp Dec 13, 2023

aneeshkp Dec 13, 2023

jzding left a comment

jzding Dec 14, 2023 •

edited

Loading

aneeshkp Dec 14, 2023

jzding left a comment

openshift-ci bot commented Dec 14, 2023

openshift-ci bot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

openshift-ci bot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

openshift-bot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-cherrypick-robot commented Dec 14, 2023

OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #270

OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #270

Conversation

aneeshkp commented Nov 30, 2023

openshift-ci-robot commented Dec 12, 2023

aneeshkp commented Dec 12, 2023

openshift-ci-robot commented Dec 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jzding left a comment

Choose a reason for hiding this comment

jzding Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jzding left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 14, 2023

openshift-ci bot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

openshift-ci bot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

openshift-bot commented Dec 14, 2023

aneeshkp commented Dec 14, 2023

openshift-cherrypick-robot commented Dec 14, 2023

jzding Dec 14, 2023 •

edited

Loading