PTP Events Generating Redundant Noise for Repeated FREERUN State Tran…

…sitions

Signed-off-by: Aneesh Puttur <[email protected]>

plugins/ptp_operator/metrics/manager.go

@@ -418,7 +418,7 @@ func (p *PTPEventManager) GenPTPEvent(ptpProfileName string, oStats *stats.Stats
 	case ptp.HOLDOVER:
 		return // do nothing for holdover
 	case ptp.FREERUN:
-		if lastClockState != ptp.HOLDOVER {
+		if lastClockState != ptp.FREERUN && lastClockState != ptp.HOLDOVER {
 			// within range
 			log.Infof(" publishing event for (profile %s) %s with last state %s and current clock state %s and offset %d for ( Max/Min Threshold %d/%d )",
 				ptpProfileName, eventResourceName, oStats.LastSyncState(), clockState, ptpOffset, threshold.MaxOffsetThreshold, threshold.MinOffsetThreshold)

plugins/ptp_operator/stats/stats_test.go

@@ -20,3 +20,8 @@ func TestStats_SetPtpDependentEventState(t *testing.T) {
 	}, nil, nil)
 	assert.Equal(t, ptp.FREERUN, s.PtpDependentEventState().CurrentPTPStateEvent)
 }
+
+func TestNewStats_EmptyState(t *testing.T) {
+	s := stats.NewStats("testCfg")
+	assert.NotEqual(t, ptp.FREERUN, s.LastSyncState())
+}