Switch to 'Result' instead of interface{} (#124)

* Switch to 'Result' instead of interface{} * Modify claim json * fix tests
redhat-best-practices-for-k8s · Jul 26, 2024 · 568c3ed · 568c3ed
1 parent f89bd9c
commit 568c3ed
Show file tree

Hide file tree

Showing 5 changed files with 128,571 additions and 341 deletions.
diff --git a/override.json b/override.json
@@ -12,7 +12,7 @@
         "claim",
         "results"
       ],
-      "overrideType": "map[string]interface{}"
+      "overrideType": "map[string]Result"
     }
   ]
 }
diff --git a/pkg/claim/schema.go b/pkg/claim/schema.go
diff --git a/pkg/claim/schema_test.go b/pkg/claim/schema_test.go
@@ -41,11 +41,6 @@ var testCases = map[string]*testCase{
 	"claim-invalid-bool-results": {
 		expectedMarshallJSONError: true,
 	},
-	// A little confusing;  since we remap the "results" field, this interface{} value is not actually checked.
-	// This is a limitation of the JSON Schema go client generator, and is perfectly fine for this context.
-	"claim-invalid-non-result-result": {
-		expectedMarshallJSONError: false,
-	},
 	"invalid-json": {
 		expectedMarshallJSONError: true,
 	},

diff --git a/pkg/claim/testdata/claim-invalid-non-result-result.json b/pkg/claim/testdata/claim-invalid-non-result-result.json