Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local policy.yaml file for Enterprise Contract #42

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonbaird
Copy link
Contributor

Rather than maintain a dependency on the ec configs at https://github.com/enterprise-contract/config let's use our own local config.

Notice that it uses a stable branch of the ec-policies repo rather than main branch. This is to reduce the change of unexpected breakages as new things are added to the ec-policies repo main branch.

Ref: https://issues.redhat.com/browse/EC-605

Copy link

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonbaird
Once this PR has been reviewed and has the lgtm label, please assign chmeliik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rather than maintain a dependency on the ec configs at
https://github.com/enterprise-contract/config let's use our own
local config.

Notice that it uses a stable branch of the ec-policies repo rather
than main branch. This is to reduce the change of unexpected
breakages as new things are added to the ec-policies repo main
branch.

Ref: https://issues.redhat.com/browse/EC-605
@simonbaird
Copy link
Contributor Author

This is an alternative to #40. I think it's better since it removes the dependency on that enterprise-contract/config repo.

@simonbaird
Copy link
Contributor Author

Another option would be to create a separate git repo just for the policy.yaml file.

Copy link

openshift-ci bot commented Jun 25, 2024

@simonbaird: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhtap-sample-pipelines-yamllint 12f178a link false /test rhtap-sample-pipelines-yamllint
ci/prow/rhtap-sample-pipelines-on-pull-request 12f178a link true /test rhtap-sample-pipelines-on-pull-request

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonbaird
Copy link
Contributor Author

simonbaird commented Jun 26, 2024

As per slack discussion, the plan is to move forward with #40 in the short term, and revisit this in future. Converting to draft.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants