Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest package versions and update tests affected by this #815

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Oct 19, 2024

Description:

  • Update go.mod to newer versions of dependencies
  • Update code/tests to reflect API changes from dependencies

Link to JIRA Story (if applicable):

Copy link
Contributor

openshift-ci bot commented Oct 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest jgwest force-pushed the update-to-latest-controller-runtime-versions-sept-2024 branch from 12407f0 to b0ff59b Compare October 19, 2024 19:07
Signed-off-by: Jonathan West <[email protected]>
@jgwest jgwest force-pushed the update-to-latest-controller-runtime-versions-sept-2024 branch from 3805119 to 34c3831 Compare October 19, 2024 19:59
Copy link

sonarcloud bot commented Oct 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.5% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

Copy link
Contributor

openshift-ci bot commented Oct 19, 2024

@jgwest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/managed-gitops-e2e-tests 34c3831 link true /test managed-gitops-e2e-tests
ci/prow/images 34c3831 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgwest jgwest merged commit 153d0ae into redhat-appstudio:main Oct 19, 2024
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant