Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use variable to specify FROM image in Dockerfiles #603

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Don't use variable to specify FROM image in Dockerfiles #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
ARG BASE_IMAGE=registry.access.redhat.com/ubi8/ubi-minimal:8.7-1085
################################################################################################
# Builder image
# Initial stage which pulls and prepares any required build dependencies for the whole monorepo
Expand Down Expand Up @@ -28,7 +27,7 @@ RUN make build
# GitOps Service image
# Provides both the 'gitops-service-backend' and 'gitops-service-cluster-agent' components
################################################################################################
FROM $BASE_IMAGE as gitops-service
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.7-1085 as gitops-service

# Install the 'shadow-utils' which contains `adduser` and `groupadd` binaries
RUN microdnf install shadow-utils \
Expand Down
3 changes: 1 addition & 2 deletions Dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
ARG BASE_IMAGE=registry.access.redhat.com/ubi8/ubi-minimal:8.7-1085
################################################################################################
# Builder image
# Initial stage which pulls and prepares any required build dependencies for the whole monorepo
Expand Down Expand Up @@ -28,7 +27,7 @@ RUN make build
# GitOps Service image
# Provides both the 'gitops-service-backend' and 'gitops-service-cluster-agent' components
################################################################################################
FROM $BASE_IMAGE as gitops-service
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.7-1085 as gitops-service

# Install the 'shadow-utils' which contains `adduser` and `groupadd` binaries
RUN yum install shadow-utils \
Expand Down
Loading