Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RHTAPWATCH-1169): Reduce permissions in the appstudio-env tier #4405

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

hmariset
Copy link
Contributor

Restrict the permissions the service account in ephemeral namespace has in creating, updating and patching the Routes and Ingresses resources.

Jira-Url: https://issues.redhat.com/browse/RHTAPWATCH-1169

@hmariset hmariset requested review from hugares and amisstea August 27, 2024 20:09
@openshift-ci openshift-ci bot requested review from mfrancisc and sadlerap August 27, 2024 20:10
@hmariset hmariset marked this pull request as draft August 27, 2024 20:10
@hmariset hmariset force-pushed the restrict-permissions branch from 17a0ccd to 92a2aa6 Compare August 27, 2024 21:09
@hugares hugares force-pushed the restrict-permissions branch from 92a2aa6 to 343ae9a Compare August 27, 2024 21:09
Restrict the permissions the service account in ephemeral namespace
has in creating, updating and patching the Routes and
Ingresses resources.

Jira-Url: https://issues.redhat.com/browse/RHTAPWATCH-1169
Signed-off-by: Homaja Marisetty <[email protected]>
@hugares hugares force-pushed the restrict-permissions branch from 343ae9a to 6ac179d Compare August 27, 2024 21:11
@hmariset hmariset marked this pull request as ready for review August 28, 2024 18:20
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisstea, hmariset, hugares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hmariset hmariset merged commit 86b4a90 into redhat-appstudio:main Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants