Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(STONEINTG-892): add proc to create override snapshot #271

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat(STONEINTG-892): add proc to create override snapshot #271

merged 2 commits into from
Jun 20, 2024

Conversation

hongweiliu17
Copy link
Member

  • add procedure to create override snapshot

Signed-off-by: Hongwei Liu [email protected]

@github-actions github-actions bot added the size: XL Extra Large label Jun 11, 2024
@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions github-actions bot added the size: XXL Very large label Jun 11, 2024
@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@hongweiliu17 hongweiliu17 force-pushed the STONEINTG-892 branch 2 times, most recently from aa19187 to f9a2d38 Compare June 11, 2024 07:59
@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

dirgim
dirgim approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongweiliu17
feat(STONEINTG-892): add proc to create override snapshot
bb0d988 
* add procedure to create override snapshot

Signed-off-by: Hongwei Liu <[email protected]>
@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

Chr1st1anSears
Chr1st1anSears reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@Chr1st1anSears Chr1st1anSears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Sorry again about that commit I accidentally made instead of suggesting. But I think this will be a good update to the doc site.

docs/modules/ROOT/pages/how-to-guides/testing_applications/con_test-overview.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc Outdated Show resolved Hide resolved
@hongweiliu17
Copy link
Member Author

Thanks, notice your comment till now. I will update them.

@hongweiliu17
Copy link
Member Author

@Chr1st1anSears PR is updated according to your comments. Thanks!

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@hongweiliu17
Copy link
Member Author

Can anyone can help to review and merge it? Thanks!

@github-actions GitHub Actions
Copy link

🚀 Preview is available at https://pr-271--boisterous-meerkat-894982.netlify.app

@dirgim dirgim requested a review from gtrivedi88 June 20, 2024 11:27
@Chr1st1anSears Chr1st1anSears merged commit 313c56a into redhat-appstudio:main Jun 20, 2024
2 checks passed
@hongweiliu17 hongweiliu17 deleted the STONEINTG-892 branch June 25, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chr1st1anSears Chr1st1anSears Chr1st1anSears left review comments

@dirgim dirgim dirgim approved these changes

@14rcole 14rcole Awaiting requested review from 14rcole

@jseseCCS jseseCCS Awaiting requested review from jseseCCS

@gtrivedi88 gtrivedi88 Awaiting requested review from gtrivedi88

Assignees
No one assigned
Labels
size: XL Extra Large size: XXL Very large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongweiliu17 @dirgim @Chr1st1anSears