Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hermetic build documentation #146

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Hermetic build documentation #146

merged 1 commit into from
Jun 27, 2023

Conversation

gtrivedi88
Copy link
Collaborator

@gtrivedi88 gtrivedi88 commented Jun 13, 2023 •
edited
Loading

@gtrivedi88 gtrivedi88 force-pushed the HACDOCS-420 branch 2 times, most recently from d1068b4 to 76da114 Compare June 13, 2023 19:28
@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

@redhat-appstudio redhat-appstudio deleted a comment from github-actions bot Jun 13, 2023
@redhat-appstudio redhat-appstudio deleted a comment from github-actions bot Jun 13, 2023
arewm
arewm suggested changes Jun 13, 2023
View reviewed changes
docs/modules/ROOT/pages/how-to-guides/proc_hermetic-builds.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/proc_hermetic-builds.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/proc_hermetic-builds.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/proc_hermetic-builds.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Show resolved Hide resolved
@gtrivedi88 gtrivedi88 force-pushed the HACDOCS-420 branch 3 times, most recently from d41ae24 to 6d9a17d Compare June 13, 2023 21:18
@redhat-appstudio redhat-appstudio deleted a comment from github-actions bot Jun 13, 2023
@redhat-appstudio redhat-appstudio deleted a comment from github-actions bot Jun 13, 2023
@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

arewm
arewm suggested changes Jun 13, 2023
View reviewed changes
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
...odules/ROOT/pages/how-to-guides/proc_prefetching-dependencies-to-support-hermetic-build.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-to-guides/proc_hermetic-builds.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/partials/con_hermetic_verification.adoc Outdated Show resolved Hide resolved
@ralphbean
Copy link
Member

@gtrivedi88 this should all probably be in how-to-guides/configuring-builds/, since it's about configuring builds. WDYT?

@gtrivedi88 gtrivedi88 force-pushed the HACDOCS-420 branch 2 times, most recently from cea8120 to 8582549 Compare June 26, 2023 08:29
@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

1 similar comment
@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

jc-berger
jc-berger approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ralphbean
ralphbean approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@ralphbean ralphbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further edits from me.

arewm
arewm approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been resolved. Thanks for this monumental effort!

@github-actions github-actions bot added the size: XS Extra small label Jun 27, 2023
@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

jc-berger
jc-berger approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

chmeliik
chmeliik approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

@gtrivedi88 gtrivedi88 merged commit 9fcaf2d into redhat-appstudio:main Jun 27, 2023
2 checks passed
@github-actions
Copy link

🚀 Preview is available at https://pr-146--boisterous-meerkat-894982.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattreid mattreid mattreid left review comments

@ralphbean ralphbean ralphbean approved these changes

@arewm arewm arewm approved these changes

@chmeliik chmeliik chmeliik approved these changes

@jc-berger jc-berger jc-berger approved these changes

@brunoapimentel brunoapimentel Awaiting requested review from brunoapimentel

Assignees
No one assigned
Labels
size: XS Extra small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gtrivedi88 @ralphbean @mattreid @arewm @chmeliik @jc-berger