fix for #942, require.cache.hasOwnProperty call for Node 8 (#947)

* fix require.cache.hasOwnProperty call for Node 8

* npm nuke script needs "rm -rf node_modules" in case node_modules doesn't exist

* add notes about dependencies to MAINTAINING.md

MAINTAINING.md

@@ -1,3 +1,9 @@
+### Dependencies
+
+- `npm install -g rimraf`
+- `npm install -g lerna`
+- `npm install -g del-cli`
+
 ### Deployment Checklist
 
 - `git checkout master && git pull upstream master`

package.json

@@ -5,7 +5,7 @@
     "bootstrap-no-i": "lerna bootstrap",
     "test": "lerna run test",
     "clean": "rimraf lerna-debug.log && lerna run clean",
-    "nuke": "npm run clean && lerna clean --yes && rm -r node_modules",
+    "nuke": "npm run clean && lerna clean --yes && rm -rf node_modules",
     "changelog": "lerna-changelog",
     "debug": "cat lerna-debug.log && for d in packages/*/npm-debug.log*; do echo $d; cat $d; done",
     "postinstall": "npm run bootstrap-no-i",

packages/react-server-cli/src/serverSideHotModuleReload.js

@@ -27,7 +27,7 @@ export default function serverSideHotModuleReload (webpackStats) {
 	// For now, loop through all of the project code to remove require caches so that we ensure the server is most up
 	// to date.
 	Object.keys(require.cache).map((filename) => {
-		if (/node_modules/.test(filename) === false && require.cache.hasOwnProperty(filename)) {
+		if (/node_modules/.test(filename) === false && Object.prototype.hasOwnProperty.call(require.cache, filename)) {
 			logger.info(`Reloading file: ${filename}`);
 			delete require.cache[filename];
 		}