This repository has been archived by the owner on Aug 22, 2018. It is now read-only.
Namespace updates #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool thanks! So will this require us to do some shuffling around of metrics/alerts/etc? 🐟 |
|
Do we need to update the tests here? i.e., https://github.com/reddit/tallier/blob/master/tally/snapshot_test.go#L80 |
|
💅 |
spladug
force-pushed
the
namespace-updates
branch
from
42c06db to
1ce3974
Compare
These namespaces are more clear to the end user and by being the same as standard statsd, we get compatibility with tools and the ability to swap to other implementations without downstream effects.
The count isn't terribly useful to us and by dropping it we can save some writes for poor busy Carbon. This is similar to what we did for timers over in a248a67.
spladug
force-pushed
the
namespace-updates
branch
from
1ce3974 to
84fcdd2
Compare
|
ok,thanks for catching that. i must not have run the test suite. i've fixed it up in both the commits that change stuff, and i've added travis support so i can't be this dumb again. (check out that pretty green check mark) 💇 |
|
Excellent! 🐟 |
|
closing this until we prioritize working on it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kevin's commit is me pulling the gofmt pass out of #10. I then just rename some strings a little.
👓 @kjoconnor