Bugfix/#16953 test journalctl checking no load error #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljblancoredborder
added
enhancement
|
The Label Bot has predicted the following:
|
malvads
requested changes
May 6, 2024
There was a problem hiding this comment.
I believe conducting such a generic test here, given its heavy processing requirements, is inappropriate. Moreover, loading all journal logs into memory is not recommended. Additionally, the generic nature of the test may lead to false positives.
We need another way to test this cases
|
I agree. I though exactly the same. |
ljblancoredborder
deleted the
bugfix/#16953_test_journalctl_checking_no_LoadError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to check if journal has LoadError about chef. This is useful because some ruby modules need it, like redborder-cgroups. However, keep in mind this kind of tests can expend too much time. In this case, it's reading the whole journal of service chef-client