lint

redBorder · Dec 5, 2024 · 7a94ae7 · 7a94ae7
1 parent a400584
commit 7a94ae7
Showing 1 changed file with 44 additions and 44 deletions.
diff --git a/spec/configuration/firewall_spec.rb b/spec/configuration/firewall_spec.rb
@@ -19,22 +19,22 @@
 
 describe 'Check existence of not allowed open ports' do
   valid_ports = Set.new [
-    '443/tcp',    #(HTTPS)
+    '443/tcp',    # (HTTPS)
     #We don't know why 5353 should be open. Remove?. Found references in our code mention pfring and snort
-    '5353/udp',   #(mDNS / Serf)
-    '2055/udp',   #(f2k)
-    '6343/udp',   #(sfacctd/pmacctd)
-    '514/tcp',    #(rsyslogd)
-    '514/udp',    #(rsyslogd)
-    '1812/udp',   #(freeradius)
-    '1813/udp',   #(freeradius)
-    '7779/tcp',   #(rb-ale)
-    '2056/tcp',   #(n2klocd)
-    '2057/tcp',   #(n2klocd)
-    '2058/tcp',   #(n2klocd)
-    '161/udp',    #(snmp)
-    '162/udp',    #(snmp)
-    '123/udp'     #(chrony)
+    '5353/udp',   # (mDNS / Serf)
+    '2055/udp',   # (f2k)
+    '6343/udp',   # (sfacctd/pmacctd)
+    '514/tcp',    # (rsyslogd)
+    '514/udp',    # (rsyslogd)
+    '1812/udp',   # (freeradius)
+    '1813/udp',   # (freeradius)
+    '7779/tcp',   # (rb-ale)
+    '2056/tcp',   # (n2klocd)
+    '2057/tcp',   # (n2klocd)
+    '2058/tcp',   # (n2klocd)
+    '161/udp',    # (snmp)
+    '162/udp',    # (snmp)
+    '123/udp'     # (chrony)
   ]
   describe 'Check existence of not allowed open ports in public zone' do
     open_ports = command('firewall-cmd --zone=public --list-ports')
@@ -55,35 +55,35 @@
 
   describe 'Check existence of not allowed open ports in home zone' do
     valid_ports += Set.new [
-      '53/tcp',     #large DNS
-      '53/udp',     #short DNS
-      '2181/tcp',   #(zookeeper client)
-      '2888/tcp',   #(zookeeper followers)
-      '3888/tcp',   #(zookeeper leader election)
-      '50505/tcp',  #(zookeeper admin)
-      '5432/tcp',   #(postgresql)
-      '7946/tcp',   #(serf)
-      '7946/udp',   #(serf)
-      '4443/tcp',   #(erchef)
-      '7980/tcp',   #(http2k)
-      '8001/tcp',   #(consul)
-      '8081/tcp',   #(druid web console)
-      '8083/tcp',   #(druid historical)
-      '8084/tcp',   #(druid broker)
-      '8080/tcp',   #(general internal http)
-      '9000/tcp',   #(minio API)
-      '9001/tcp',   #(minio console)
-      '8300/tcp',   #(consul RPC)
-      '8301/tcp',   #(consul/serf LAN)
-      '8301/udp',   #(consul/serf LAN)
-      '8302/tcp',   #(consul/serf WAN)
-      '8302/udp',   #(consul/serf WAN)
-      '8400/tcp',   #(consul)           deprecated,TODO investigate to close
-      '8500/tcp',   #(consul web console)
-      '9092/tcp',   #(kafka)
-      '11211/tcp',  #(memcached)
-      '11211/udp',  #(memcached)
-      '27017/tcp',  #(mongodb)
+      '53/tcp',     # large DNS
+      '53/udp',     # short DNS
+      '2181/tcp',   # (zookeeper client)
+      '2888/tcp',   # (zookeeper followers)
+      '3888/tcp',   # (zookeeper leader election)
+      '50505/tcp',  # (zookeeper admin)
+      '5432/tcp',   # (postgresql)
+      '7946/tcp',   # (serf)
+      '7946/udp',   # (serf)
+      '4443/tcp',   # (erchef)
+      '7980/tcp',   # (http2k)
+      '8001/tcp',   # (consul)
+      '8081/tcp',   # (druid web console)
+      '8083/tcp',   # (druid historical)
+      '8084/tcp',   # (druid broker)
+      '8080/tcp',   # (general internal http)
+      '9000/tcp',   # (minio API)
+      '9001/tcp',   # (minio console)
+      '8300/tcp',   # (consul RPC)
+      '8301/tcp',   # (consul/serf LAN)
+      '8301/udp',   # (consul/serf LAN)
+      '8302/tcp',   # (consul/serf WAN)
+      '8302/udp',   # (consul/serf WAN)
+      '8400/tcp',   # (consul)           deprecated,TODO investigate to close
+      '8500/tcp',   # (consul web console)
+      '9092/tcp',   # (kafka)
+      '11211/tcp',  # (memcached)
+      '11211/udp',  # (memcached)
+      '27017/tcp',  # (mongodb)
     ]
 
     open_ports = command('firewall-cmd --zone=home --list-ports')